Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[air] Add annotation for Tune module. #27060

Merged
merged 15 commits into from
Jul 27, 2022
Merged

[air] Add annotation for Tune module. #27060

merged 15 commits into from
Jul 27, 2022

Conversation

xwjiang2010
Copy link
Contributor

@xwjiang2010 xwjiang2010 commented Jul 26, 2022 •
edited
Loading

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010
[stage 1] update tune annotation.
be204f3 
Signed-off-by: xwjiang2010 <[email protected]>
@xwjiang2010
part 2
c5508e5 
Signed-off-by: xwjiang2010 <[email protected]>
@xwjiang2010 xwjiang2010 changed the title Check annotation [WIP] Add annotation for Tune module. Jul 26, 2022
@xwjiang2010
minor fixes
f890e1b 
Signed-off-by: xwjiang2010 <[email protected]>
@xwjiang2010
part 3
c01bc2a 
Signed-off-by: xwjiang2010 <[email protected]>
@xwjiang2010
actually enable lint check.
f8dbb62 
Signed-off-by: xwjiang2010 <[email protected]>
@xwjiang2010
fix test
e96d783 
Signed-off-by: xwjiang2010 <[email protected]>
@xwjiang2010
fix test...
e59ddc1 
Signed-off-by: xwjiang2010 <[email protected]>
@xwjiang2010 xwjiang2010 added this to the Ray AIR milestone Jul 27, 2022
krfricke
krfricke reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, minor requests

python/ray/tune/execution/placement_groups.py Outdated Show resolved Hide resolved
python/ray/tune/logger/logger.py Outdated Show resolved Hide resolved
krfricke
krfricke approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

xwjiang2010 and others added 3 commits July 27, 2022 08:24
@xwjiang2010
_force_on_current_node
edd6316 
Signed-off-by: xwjiang2010 <[email protected]>
Merge remote-tracking branch 'upstream/master' into tune/fn-annotations
a6de472 
# Conflicts:
#	python/ray/tune/tune.py
Resolve more conflicts
03694d6 
Signed-off-by: Kai Fricke <[email protected]>
Kai Fricke added 2 commits July 27, 2022 17:28
Merge branch 'master' into tune/fn-annotations
d19ccd6 
# Conflicts:
#	ci/lint/check_api_annotations.py
#	python/ray/tune/logger/logger.py
Merge branch 'master' into tune/fn-annotations
338cecc
@xwjiang2010
Copy link
Contributor Author

Thanks @krfricke !

@richardliaw richardliaw changed the title [WIP] Add annotation for Tune module. [air] Add annotation for Tune module. Jul 27, 2022
@xwjiang2010
Copy link
Contributor Author

python/ray/tune/tests/test_tuner_restore.py passes locally.

@richardliaw richardliaw merged commit eb69c1c into ray-project:master Jul 27, 2022
xwjiang2010 added a commit to xwjiang2010/ray that referenced this pull request Jul 28, 2022
@xwjiang2010
[air] Add annotation for Tune module. (ray-project#27060)
845eb46 
Co-authored-by: Kai Fricke <[email protected]>
@xwjiang2010 xwjiang2010 mentioned this pull request Jul 28, 2022
Merged
7 tasks
xwjiang2010 added a commit to xwjiang2010/ray that referenced this pull request Jul 28, 2022
@xwjiang2010
[air] Add annotation for Tune module. (ray-project#27060)
9314535 
Signed-off-by: xwjiang2010 <[email protected]>
scv119 pushed a commit that referenced this pull request Jul 29, 2022
@xwjiang2010
[air] Add annotation for Tune module. (#27060) (#27210)
4bf33ef 
Signed-off-by: xwjiang2010 <[email protected]>

As a follow up to #27060.
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
@xwjiang2010
[air] Add annotation for Tune module. (ray-project#27060)
5f25a98 
Co-authored-by: Kai Fricke <[email protected]>
Signed-off-by: Stefan van der Kleij <[email protected]>
@krfricke krfricke mentioned this pull request Aug 26, 2022
Merged
7 tasks
krfricke added a commit that referenced this pull request Aug 26, 2022
@krfricke
[tune] Re-enable progress metric detection (#28130)
f59dcdc 
The API cleanup in #27060 introduced a regression when merging latest master - changes from #26967 were effectively disabled, retaining cluttered output in rllib with verbose=2.

Signed-off-by: Kai Fricke <[email protected]>
@xwjiang2010 xwjiang2010 deleted the check_annotation branch July 26, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kouroshHakha kouroshHakha kouroshHakha approved these changes

@krfricke krfricke krfricke approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw

@amogkam amogkam Awaiting requested review from amogkam

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@Yard1 Yard1 Awaiting requested review from Yard1

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@sven1977 sven1977 Awaiting requested review from sven1977 sven1977 is a code owner

@gjoliver gjoliver Awaiting requested review from gjoliver

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

Assignees

@richardliaw richardliaw

@krfricke krfricke

Labels
None yet
Projects
None yet
Milestone
Ray AIR
Development

Successfully merging this pull request may close these issues.
5 participants
@xwjiang2010 @krfricke @kouroshHakha @scv119 @richardliaw